Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec 2.22.0 → 2.24.0 (minor) #805

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 15, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.22.0 → 2.24.0) · Repo · Changelog

Release Notes

2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@ydah)
  • Add new RSpec/Eq cop. (@ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@ydah)

2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@marocchino)

2.23.1

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. (@ydah)
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. (@bquorning)

2.23.0

  • Add new RSpec/Rails/NegationBeValid cop. (@ydah)
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. (@ydah)
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. (@ydah)
  • Update the message output of RSpec/ExpectActual to include the word 'value'. (@corydiamand)
  • Fix a false negative for RSpec/Pending when it without body. (@ydah)
  • Add new RSpec/ReceiveMessages cop. (@ydah)
  • Change default.yml path to use **/spec/* instead of spec/*. (@ydah)
  • Add AllowedIdentifiers and AllowedPatterns configuration option to RSpec/IndexedLet. (@ydah)
  • Fix RSpec/NamedSubject when block has no body. (@splattael)
  • Fix RSpec/LetBeforeExamples autocorrect incompatible with RSpec/ScatteredLet autocorrect. (@ydah)
  • Update RSpec/Focus to support shared_context and shared_examples (@tmaier)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.52.0 → 1.56.3) · Repo · Changelog

Release Notes

1.56.3

Bug fixes

  • #12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. (@koic)
  • #12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. (@ymap)
  • #12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. (@ymap)
  • #12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. (@koic)
  • #12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. (@koic)
  • #12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. (@koic)
  • #12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. (@koic)
  • #12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. (@koic)
  • #12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. (@koic)
  • #12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. (@ymap)
  • #12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. (@koic)
  • #12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. (@owst)
  • #12185: Set target version for Layout/HeredocIndentation. (@tagliala)

1.56.2

Bug fixes

  • #12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. (@ymap)
  • #12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. (@koic)
  • #12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. (@koic)
  • #12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. (@koic)
  • #12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. (@owst)
  • #12154: Fix incorrect diagnosticProvider value of LSP. (@koic)

1.56.1

Bug fixes

  • #12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)
  • #12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)
  • #12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)
  • #12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)
  • #12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)
  • #12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)
  • #12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)
  • #12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)
  • #12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)
  • #12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)
  • #12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

1.56.0

New features

  • #12074: Add new Bundler/DuplicatedGroup cop. (@OwlKing)
  • #12078: Make LSP server support rubocop.formatAutocorrectsAll execute command. (@koic)

Bug fixes

  • #12106: Fix a false negative for Style/RedundantReturn when returning value with guard clause and return is used. (@koic)
  • #12095: Fix a false positive for Style/Alias when EncforcedStyle: prefer_alias and using alias with interpolated symbol argument. (@koic)
  • #12098: Fix a false positive for Style/ClassEqualityComparison when comparing interpolated string class name for equality. (@koic)
  • #12102: Fix an error for Style/LambdaCall when using nested lambda call x.().(). (@koic)
  • #12099: Fix an incorrect autocorrect for Style/Alias when EncforcedStyle: prefer_alias_method and using alias with interpolated symbol argument. (@koic)
  • #12085: Fix an error for Lint/SuppressedException when AllowNil: true is set and endless method definition is used. (@koic)
  • #12087: Fix false positives for Style/ArgumentsForwarding with additional args/kwargs in def/send nodes. (@owst)
  • #12071: Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal in a percent style array. (@jasondoc3)
  • #12061: Support regex in StringLiteralsInInterpolation. (@jonas054)
  • #12091: With --fail-level A ignore non-correctable offenses at :info severity. (@naveg)

Changes

  • #12094: Add base64 gem to runtime dependency to suppress Ruby 3.3's warning. (@koic)

1.55.1

Bug fixes

  • #12068: Fix a false positive for Style/ReturnNilInPredicateMethodDefinition when the last method argument in method definition is nil. (@koic)
  • #12082: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for with multiple variables. (@koic)
  • #12079: Fix an error for Style/MixinGrouping when mixin method has no arguments. (@koic)
  • #11637: Correct Rubocop for private_class_method method documentation. (@bigzed)
  • #12070: Fix false positive in Style/ArgumentsForwarding when receiver forwards args/kwargs. (@owst)

1.55.0

New features

  • #11794: Add support to Style/ArgumentsForwarding for anonymous arg/kwarg forwarding in Ruby 3.2. (@owst)
  • #12044: Make LSP server support layoutMode option to run layout cops. (@koic)
  • #12056: Make LSP server support lintMode option to run lint cops. (@koic)
  • #12046: Make ReturnNilInPredicateMethodDefinition aware of nil at the end of predicate method definition. (@koic)

Bug fixes

  • #12055: Allow parentheses in single-line match patterns when using the omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #12050: Fix a false positive for Layout/RedundantLineBreak when inspecting the % form string %\n\n. (@koic)
  • #12063: Fix Style/CombinableLoops when one of the loops is empty. (@fatkodima)
  • #12059: Fix a false negative for Style/StringLiteralsInInterpolation for symbols with interpolation. (@fatkodima)
  • #11834: Fix false positive for when variable in inside conditional branch in nested node. (@alexeyschepin)
  • #11802: Improve handling of [] and () with percent symbol arrays. (@jasondoc3)
  • #12052: Fix "Subfolders can't include glob special characters". (@meric426, @loveo)
  • #12062: Fix LoadError when loading RuboCop from a symlinked location on Windows. (@p0deje)

Changes

  • #12064: Make Style/RedundantArgument aware of exit and exit!. (@koic)
  • #12015: Mark Style/HashConversion as unsafe autocorrection. (@koic)

1.54.2

Bug fixes

  • #12043: Fix a false negative for Layout/ExtraSpacing when some characters are vertically aligned. (@koic)
  • #12040: Fix a false positive for Layout/TrailingEmptyLines to prevent the following incorrect autocorrection when inspecting the % form string %\n\n. (@koic)
  • #1867: Fix an error when AllCops:Exclude is empty in .rubocop.yml. (@koic)
  • #12034: Fix invalid byte sequence in UTF-8 error when using an invalid encoding string. (@koic)
  • #12038: Output the "server restarting" message to stderr. (@knu)

1.54.1

Bug fixes

  • #12024: Fix a false positive for Lint/RedundantRegexpQuantifiers when interpolation is used in a regexp literal. (@koic)
  • #12020: This PR fixes an infinite loop error for Layout/SpaceAfterComma with Layout/SpaceBeforeSemicolon when autocorrection conflicts. (@koic)
  • #12014: Fix an error for Lint/UselessAssignment when part of a multiple assignment is enclosed in parentheses. (@koic)
  • #12011: Fix an error for Metrics/MethodLength when using a heredoc in a block without block arguments. (@koic)
  • #12010: Fix false negatives for Style/RedundantRegexpArgument when using safe navigation operator. (@koic)

1.54.0

New features

  • #12000: Support safe or unsafe autocorrect config for LSP. (@koic)

Bug fixes

  • #12005: Fix a false negative for Lint/Debugger when using debugger method inside lambda. (@koic)
  • #11986: Fix a false positive for Lint/MixedCaseRange when the number of characters at the start or end of range is other than 1. (@koic)
  • #11992: Fix an unexpected NoMethodError for built-in language server when an internal error occurs. (@koic)
  • #11994: Fix an error for Layout/LineEndStringConcatenationIndentation when inspecting the % from string %\n\n. (@koic)
  • #12007: Fix an error for Layout/SpaceAroundOperators when using unary operator with double colon. (@koic)
  • #11996: Fix an error for Style/IfWithSemicolon when without branch bodies. (@koic)
  • #12009: Fix an error for Style/YodaCondition when equality check method is used without the first argument. (@koic)
  • #11998: Fix an error when inspecting blank heredoc delimiter. (@koic)
  • #11989: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using unicode chars. (@koic)
  • #12001: Fix code length calculator for method calls with heredoc. (@fatkodima)
  • #12002: Fix Lint/Void cop for __ENCODING__ constant. (@fatkodima)

Changes

  • #11983: Add Ridgepole files to default Include list. (@ydah)
  • #11738: Enhances empty_line_between_defs to treat configured macros like defs. (@catwomey)

1.53.1

Bug fixes

  • #11974: Fix an error for Style/RedundantCurrentDirectoryInPath when using string interpolation in require_relative. (@koic)
  • #11981: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using double quote and single quote characters. (@koic)
  • #11836: Should not offense single-quoted symbol containing double quotes in Lint/SymbolConversion . (@KessaPassa)

1.53.0

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@rwstauner)

Changes

  • #11904: Mark Layout/ClassStructure as unsafe to autocorrect. (@nevans)
  • #8506: Add AllowedParentClasses config to Lint/MissingSuper. (@iMacTia)

1.52.1

Bug fixes

  • #11944: Fix an incorrect autocorrect for Style/SoleNestedConditional with Style/MethodCallWithArgsParentheses. (@koic)
  • #11930: Fix exception on Lint/InheritException when class definition has non-constant siblings. (@rafaelfranca)
  • #11919: Fix an error for Lint/UselessAssignment when a variable is assigned and unreferenced in for. (@koic)
  • #11928: Fix an incorrect autocorrect for Lint/AmbiguousBlockAssociation. (@koic)
  • #11915: Fix a false positive for Lint/RedundantSafeNavigation when &. is used for to_s, to_i, to_d, and other coercion methods. (@lucthev)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ racc (indirect, 1.7.0 → 1.7.1) · Repo · Changelog

Release Notes

1.7.1

What's Changed

  • Use released version of test-unit-ruby-core by @hsbt in #220
  • Fix place to specify rake-compiler version by @nobu in #223
  • Embedded path by @nobu in #221

Full Changelog: v1.7.0...v1.7.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:

↗️ regexp_parser (indirect, 2.8.0 → 2.8.1) · Repo · Changelog

Release Notes

2.8.1 (from changelog)

Fixed

  • support for extpict unicode property, added in Ruby 2.6
  • support for 10 unicode script/block properties added in Ruby 3.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ rexml (indirect, 3.2.5 → 3.2.6) · Repo · Changelog

Release Notes

3.2.6

Improvements

  • Required Ruby 2.5 or later explicitly.
    GH-69
    [Patch by Ivo Anjo]

  • Added documentation for maintenance cycle.
    GH-71
    [Patch by Ivo Anjo]

  • Added tutorial.
    GH-77
    GH-78
    [Patch by Burdette Lamar]

  • Improved performance and memory usage.
    GH-94
    [Patch by fatkodima]

  • REXML::Parsers::XPathParser#abbreviate: Added support for
    function arguments.
    GH-95
    [Reported by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added support for string
    literal that contains double-quote.
    GH-96
    [Patch by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added missing / to
    :descendant_or_self/:self/:parent.
    GH-97
    [Reported by pulver]

  • REXML::Parsers::XPathParser#abbreviate: Added support for more patterns.
    GH-97
    [Reported by pulver]

Fixes

  • Fixed a typo in NEWS.
    GH-72
    [Patch by Spencer Goodman]

  • Fixed a typo in NEWS.
    GH-75
    [Patch by Andrew Bromwich]

  • Fixed documents.
    GH-87
    [Patch by Alexander Ilyin]

  • Fixed a bug that Attriute convert ' and ' even when
    attribute_quote: :quote is used.
    GH-92
    [Reported by Edouard Brière]

  • Fixed links in tutorial.
    GH-99
    [Patch by gemmaro]

Thanks

  • Ivo Anjo

  • Spencer Goodman

  • Andrew Bromwich

  • Burdette Lamar

  • Alexander Ilyin

  • Edouard Brière

  • fatkodima

  • pulver

  • gemmaro

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:

🆕 base64 (added, 0.1.1)

🆕 language_server-protocol (added, 3.17.0.3)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Sep 29, 2023

Closing because this update has already been applied

@depfu depfu bot closed this Sep 29, 2023
@depfu depfu bot deleted the depfu/update/rubocop-rspec-2.24.0 branch September 29, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants